Skip to content
This repository was archived by the owner on May 22, 2020. It is now read-only.

[RUN-5386] Add chromeVersion property to getRuntimeInfo interface #368

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[RUN-5386] Add chromeVersion property to getRuntimeInfo interface #368

wants to merge 2 commits into from

Conversation

@yongjich
Copy link

@yongjich yongjich commented Oct 17, 2019

Description of Change

Add chromeVersion property to runtimeInfo interface

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • Integration tests added in this repo and in the test dashboard
  • PR title starts with the JIRA ticket pull request process

Release Notes

Notes:

@finos-admin
Copy link

finos-admin commented Oct 17, 2019

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yongjich). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@yongjich yongjich changed the title add chromeVersion property to getRuntimeInfo interface [RUN-5386] Add chromeVersion property to getRuntimeInfo interface Oct 17, 2019
@yongjich yongjich mentioned this pull request Oct 17, 2019
Open
6 tasks
@openfin-github-bot openfin-github-bot bot added the auto testing started Bot started automated testing label Oct 17, 2019
@openfin-github-bot
Copy link

openfin-github-bot bot commented Oct 17, 2019

c953a71

Git

  • core: develop
  • js-adapter: develop <= RUN-5683-getRuntimeInfo (c953a71)
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 17, 2019
dhamberlin
dhamberlin previously approved these changes Oct 17, 2019
View reviewed changes
pbaize
pbaize suggested changes Oct 18, 2019
View reviewed changes
Copy link
Collaborator

@pbaize pbaize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add this to the docs too?

@finos-admin
Copy link

finos-admin commented Oct 21, 2019

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yongjich). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@finos-admin finos-admin removed the auto testing done Bot completed automated testing label Oct 21, 2019
@openfin-github-bot openfin-github-bot bot added the auto testing started Bot started automated testing label Oct 21, 2019
@openfin-github-bot
Copy link

openfin-github-bot bot commented Oct 21, 2019

8d5c9e5

Git

  • core: develop
  • js-adapter: develop <= RUN-5683-getRuntimeInfo (8d5c9e5)
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@pbaize pbaize pbaize requested changes

@licui3936 licui3936 licui3936 approved these changes

@dhamberlin dhamberlin dhamberlin approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

auto testing done Bot completed automated testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yongjich @finos-admin @licui3936 @pbaize @dhamberlin